Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-builder: Minor updates to README.md #270

Merged
merged 1 commit into from
Dec 13, 2024
Merged

node-builder: Minor updates to README.md #270

merged 1 commit into from
Dec 13, 2024

Conversation

ms-mahuber
Copy link

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Updates to node-builder README:

  • no longer install make package, is part of meta package
  • remove superfluous popd
  • add note on permissive policy for ConfPods UVM builds
Test Methodology

Follow steps by hand

@ms-mahuber ms-mahuber requested review from a team as code owners December 13, 2024 18:34
@sprt sprt added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Dec 13, 2024
@ms-mahuber
node-builder: Minor updates to README.md
7ac0143 
- no longer install make package, is part of meta package
- remove superfluous popd
- add note on permissive policy for ConfPods UVM builds

Signed-off-by: Manuel Huber <[email protected]>
@ms-mahuber ms-mahuber force-pushed the mahuber/build-readme-amend branch from 3f67feb to 7ac0143 Compare December 13, 2024 22:22
@ms-mahuber ms-mahuber merged commit e536fdb into msft-main Dec 13, 2024
45 of 53 checks passed
@ms-mahuber ms-mahuber deleted the mahuber/build-readme-amend branch December 27, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

Assignees
No one assigned
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-mahuber @danmihai1 @sprt