Windows support for Service tool added. #3573
Conversation
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
5 times, most recently
from
5678bbc to
2f38007
Compare
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
from
9cfc7ab to
727572d
Compare
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
from
5b555e0 to
72582c5
Compare
This pull request adds Windows support for the Service tool.
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
from
72582c5 to
30a8249
Compare
| force_run=True, | ||
| ) | ||
| except LisaException as identifier: | ||
| if "Cannot find any service with service name" in str(identifier): |
There was a problem hiding this comment.
With this error message, when a non-exist service will be stop or restarted in a normal state? if the service doesn't exist, it should fail earlier, instead of stop/start it without errors.
In case it's really needed, please call check_service_exists before stop/start, and raise all errors. The code is clean and easy to read. But before apply like this, please explain when a non-exist service is started or stopped.
There was a problem hiding this comment.
Adding an extra call to check_service_exists will add latency. Since restart/stop can capture it as part of the reason for failure. I think we can keep this message.
I added extra messages to capture reasons for not stopping a service. One of the reasons for not able to stop is dependent services.
This pull request adds Windows support for the Service tool.