Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/playwright-core/src/client/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ export function isTargetClosedError(error: Error) {
}

export function serializeError(e: any): SerializedError {
if (isError(e))
return { error: { message: e.message, stack: e.stack, name: e.name } };
if (isError(e)) {
const serialized: SerializedError = { error: { message: e.message, stack: e.stack, name: e.name } };
if (e.code)
serialized.error!.code = e.code;
return serialized;
}
return { value: serializeValue(e, value => ({ fallThrough: value })) };
}

Expand All @@ -71,5 +75,7 @@ export function parseError(error: SerializedError): PlaywrightError {
else
e = Object.assign(new PlaywrightError(error.error.message), { name: error.error.name });
e.stack = error.error.stack || '';
if (error.error.code)
(e as any).code = error.error.code;
return e;
}
10 changes: 8 additions & 2 deletions packages/playwright-core/src/server/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,12 @@ export function isTargetClosedError(error: Error) {
}

export function serializeError(e: any): SerializedError {
if (isError(e))
return { error: { message: e.message, stack: e.stack, name: e.name } };
if (isError(e)) {
const serialized: SerializedError = { error: { message: e.message, stack: e.stack, name: e.name } };
if (e.code)
serialized.error!.code = e.code;
return serialized;
}
return { value: serializeValue(e, value => ({ fallThrough: value })) };
}

Expand All @@ -63,5 +67,7 @@ export function parseError(error: SerializedError): Error {
const e = new Error(error.error.message);
e.stack = error.error.stack || '';
e.name = error.error.name;
if (error.error.code)
(e as any).code = error.error.code;
return e;
}
1 change: 1 addition & 0 deletions packages/protocol/src/structs.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ export type SerializedError = {
message: string,
name: string,
stack?: string,
code?: string,
},
value?: SerializedValue,
};
Expand Down