feat(test-runner): read last failed tests from --last-failed=<file> - #42995
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoSep 29, 2026
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟡 The two VS Code extension failures are probably not caused by this PR, but I couldn't prove they're flakesBoth failures are DetailsBesides the two failures, the report has 5 flaky tests (passed on retry), and they're in areas this PR doesn't touch. The two real failures come from the Uncertain
Triaged by the Playwright bot - agent run |
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
Sep 29, 2026
| ['--last-failed', { description: `Only re-run the failures` }], | ||
| ['--last-failed-file <file>', { description: `Override the default path for the last-run JSON file used with --last-failed (default: <outputDir>/.last-run.json). Same as PLAYWRIGHT_LAST_RUN_OUTPUT_FILE environment variable.` }], | ||
| ['--last-failed [file]', { description: `Only re-run the failures. Optionally takes a path to the last-run JSON file to read the failures from, use --last-failed=<file> form (default: the file last run is written to)` }], | ||
| ['--last-failed-file <file>', { description: `Path to write the last-run JSON file to (default: <outputDir>/.last-run.json). Same as PLAYWRIGHT_LAST_RUN_OUTPUT_FILE environment variable.` }], |
There was a problem hiding this comment.
--last-failed-output-file to disambiguate
Dmitry Gozman (dgozman)
approved these changes
Sep 29, 2026
| return undefined; | ||
| try { | ||
| const lastRunInfo = JSON.parse(await fs.promises.readFile(this._lastRunFile, 'utf8')) as LastRunInfo; | ||
| const lastRunInfo = JSON.parse(await fs.promises.readFile(this._outputFile, 'utf8')) as LastRunInfo; |
Collaborator
There was a problem hiding this comment.
Why not call readFailedTests() here?
Member
Author
There was a problem hiding this comment.
This is gone now
`--last-failed=<file>` reads the failures from the given last run file and never writes to it. The run fails when that file is missing or malformed. Without a path, `--last-failed` reads `<outputDir>/.last-run.json`. `--last-failed-file` is renamed to `--last-run-output-file` and only controls where the last run file is written, same as `PLAYWRIGHT_LAST_RUN_OUTPUT_FILE`. Relative paths are resolved against the current working directory.
Pavel Feldman (pavelfeldman)
force-pushed
the
last-failed-input-file
branch
from
September 29, 2026 20:03
6d8233b to
32cb420
Compare
Pavel Feldman (pavelfeldman)
merged commit Sep 29, 2026
3456aa7
into
microsoft:main
41 of 43 checks passed
Contributor
Test results for "tests 1"5 flaky52401 passed, 1243 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 8827 passed, 1480 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The two MCP Firefox failures are pre-existing flakesBoth tests fail intermittently on DetailsThe latest MCP run at Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--last-failed=<file>reads the failures from the given last run file and never writes to it; the run fails if the file is missing or malformed. Without a path,--last-failedreads<outputDir>/.last-run.json.--last-failed-fileis renamed to--last-run-output-file. It only controls where the last run file is written, same asPLAYWRIGHT_LAST_RUN_OUTPUT_FILE.