Repository navigation
Add icon to About menu item in settings - #11652
Open
Dmitriy Antipov (THEb0nny) wants to merge 1 commit into
Open
Dmitriy Antipov (THEb0nny) wants to merge 1 commit into
Dmitriy Antipov (THEb0nny) wants to merge 1 commit into
Conversation
Add icon info circle to the About... option in SettingsMenu and ProjectSettingsMenu so that all settings menu items consistently display an icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Settings dropdown menu, every item (such as Project Settings, Extensions, Print, Save, Delete, Version History, Language, Theme, Report Abuse, Reset) has an icon on the left (or a checkbox / avatar). The only item without an icon was "About...".
This PR adds
leftIcon: "icon info circle"to the "About..." menu item in bothSettingsMenuandProjectSettingsMenuso that it consistently displays the information circle icon and aligns with the rest of the menu items.Changes
webapp/src/container.tsx: AddedleftIcon: "icon info circle"toSettingsMenuAbout item.webapp/src/projects.tsx: AddedleftIcon: "icon info circle"toProjectSettingsMenuAbout item.