Skip to content

Pull Pylance with Pyright 1.1.414 - #11903

Merged
Bill Schnurr (bschnurr) merged 4 commits into
mainfrom
pull-pylance-with-pyright-1.1.414-20261021-174246
Oct 21, 2026
Merged

Pull Pylance with Pyright 1.1.414#11903
Bill Schnurr (bschnurr) merged 4 commits into
mainfrom
pull-pylance-with-pyright-1.1.414-20261021-174246

Conversation

@heejaechang

@heejaechang Heejae Chang (heejaechang) commented Oct 21, 2026 •
edited by bschnurr
Loading

Copy link
Copy Markdown
Collaborator

Summary

Sync Pylance changes into Pyright 1.1.414, including tokenizer improvements, workspace diagnostics fixes, and maintenance updates.

  • Reduce unnecessary tokenization in references, rename, call hierarchy, and symbol indexing by using existing parser line information.
  • Reuse tokens retained in the parse tree when rebuilding tokenizer output, preserving notebook tokenization settings and guarding against stale cache updates.
  • Clean up workspace diagnostic requests on cancellation, replacement, configuration changes, and shutdown.
  • Add opt-in workspace analysis progress reporting for files and notebook cells.
  • Correct import-edit matching to prefer the resolved from module name.
  • Refresh dependencies, dependency-update tooling, and build pipeline configuration.

CI reliability fixes

  • Wait for capability-unregistration responses before disposing the test server connection, preventing worker crashes and subsequent test timeouts.
  • Retry pnpm setup once in PR benchmark shards; repeated setup failures remain fatal.
  • Allow descriptive kernel-version differences when merging benchmark shards, retaining all platform descriptions while still requiring matching benchmark settings and runner profiles.

@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@heejaechang

Heejae Chang (heejaechang) commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

🟢 Pyright CLI QA — 7fc0e4b3 — verdict: green

Automated CLI checks compared this change with its base revision.
9 focused check(s) completed.

No new behavior difference was detected.

@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "b2ebbe2dd1e7568e000880ffbed4a477d1a1c70959e062656163490b7a481107": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

bschnurr
Bill Schnurr (bschnurr) approved these changes Oct 21, 2026
View reviewed changes

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Oct 21, 2026
rchiodo
Rich Chiodo (rchiodo) approved these changes Oct 21, 2026
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr
Wait for test server unregistration responses before teardown
27d8839 
Prevent delayed client responses from crashing the reused language server worker. Add a regression covering capability unregistration beyond the previous polling limit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "91fe30b6be846b60971dd41c130880e966fe1410435721156651d82171ef96f4": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026

Copy link
Copy Markdown
Member

/benchmark

@bschnurr
Retry transient pnpm setup failures in PR benchmarks
0244858 
Retry the pinned setup action once from its clean installation directory. Keep repeated setup failures fatal and preserve benchmark measurement and result completeness checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "ff31c32042a0004da4c54617f46dea8d229d19d530c951e2ad6bebcad2fe09ee": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026

Copy link
Copy Markdown
Member

/benchmark

@bschnurr
Allow descriptive kernel differences across benchmark shards
7fc0e4b 
Retain all platform descriptions when hosted runners use different kernel versions, while enforcing matching benchmark and runner profiles. Cover mixed kernels and rejection of incompatible environments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bschnurr

Bill Schnurr (bschnurr) commented Oct 21, 2026

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "b4cc3460647254bbbc2a8203c1cc66b570e34862eb72c79f9d974d41cd298d2f": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr
Bill Schnurr (bschnurr) merged commit cac166a into main Oct 21, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bschnurr Bill Schnurr (bschnurr) bschnurr approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes

Assignees

No one assigned

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heejaechang @bschnurr @rchiodo