Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Improve agent retrieval by passing necessary kwargs. Add unit tests. #10116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented Jan 8, 2025

Motivation and Context

The assistant retrieval methods for OpenAI and AzureOpenAI didn't propagate the api_key or client, if specified. For AzureOpenAI, it's also important to propagate more settings info.

Description

This PR:

  • improves the handling for retrieving an agent by making sure we pass along specified keyword arguments
  • adds unit tests to ensure the new functionality works as expected

Contribution Checklist

@moonbox3 moonbox3 self-assigned this Jan 8, 2025
@moonbox3 moonbox3 requested a review from a team as a code owner January 8, 2025 03:08
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jan 8, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 8, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/open_ai
   azure_assistant_agent.py106298%271, 288
   open_ai_assistant_agent.py105298%252, 272
TOTAL16645176989% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2999 4 💤 0 ❌ 0 🔥 1m 23s ⏱️

@moonbox3 moonbox3 added the agents label Jan 8, 2025
@moonbox3 moonbox3 enabled auto-merge January 8, 2025 21:51
@moonbox3 moonbox3 added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents python Pull requests for the Python Semantic Kernel
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants