-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add Azure DB for PostgreSQL vector store #9326
base: main
Are you sure you want to change the base?
Conversation
Python Unit Test Overview
|
Hi @lossyrob, is this PR ready for a review? |
c758b12
to
09477f1
Compare
Python Test Coverage Report •
Python Unit Test Overview
|
@moonbox3 sorry for the late reply, I'm just getting back from parental leave. This is ready for review, but I'm still working on testing. I don't see a good way to unit test this code, as it really only adds the ability to create a custom psycopg connection class that uses Entra auth, which is hard to mock and have substantial tests around. I need to create integration tests, which will be more substantial. This will require a PostgreSQL flex server that uses Entra authentication, along with a service principal available to the integration test runner to utilize during the integration tests. Is a service principal already available in that environment? Would it be possible to get a small Azure DB for PostgreSQL flex server with entra auth enabled and the proper IAM roles assigned in the integration test environment? |
48f25fc
to
e379c80
Compare
Thanks for your reply, @lossyrob. Let me check on this for you and I'll get back to you soon. |
Motivation and Context
This adds a VectorStore for Azure DB for PostgreSQL.
Currently, the only additional functionality this provides over the PostgresVectorStore is to easily connect to the database using Entra authentication. In the future, we will add capability to leverage the new DiskANN indexing.
Description
TODO:
Contribution Checklist