Repository navigation
[main] Update Roslyn testing packages to 1.1.4 - #12344
Conversation
…g from 1.1.3-beta1.26255.1 to 1.1.4 --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing dependency-version: 1.1.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
There was a problem hiding this comment.
🟡 Changes recommended
The six Bazel test-support pins still resolve the old harness, leaving native analyzer tests out of sync with MSBuild’s 1.1.4 harness and violating the documented pin-alignment requirement.
1 open issue
What changed in this PR
Updates the shared Roslyn testing dependency version used by MSTest analyzer tests from 1.1.3-beta1.26255.1 to stable 1.1.4.
Changes:
- Updates the central
MicrosoftCodeAnalysisAnalyzerTestingVersionproperty. - Applies the upgrade to six C# and Visual Basic analyzer, code-fix, and refactoring testing packages—not only the package named in the title.
Test-value evidence: Static inspection only; no build or test results were supplied or executed.
| File | Description |
|---|---|
Directory.Packages.props |
Raises the shared version for six Roslyn testing packages to 1.1.4. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
There was a problem hiding this comment.
🧪 Test quality review — PR #12344
Compared merge base 182908fecaf00e54664be23e82b575716dc76199 with head af0b8bfd55ea8c02906b79c06ce22b60f0eb08de. Evidence applies to this head, not every intermediate commit.
Test-value evidence
| Contract | Evidence | Result |
|---|---|---|
Roslyn analyzer-testing packages bumped from 1.1.3-beta1.26255.1 to 1.1.4 (Directory.Packages.props, Bazel lock, paket files) |
Dependency change only. The existing analyzer and code-fix unit tests are the consumers. No paired execution records were accessible. | Not applicable / unverified |
Dependabot roslyn-testing group added |
Configuration only. | Not applicable |
eng/bazel/tests-support/package-integrity.json reduced to {} |
Static observation only. I could not confirm whether this is intended generator output. | Unverified |
🧵 Parallel safety
STATUS: PARTIAL. The only parallelization candidate is Directory.Packages.props, and its change is a package version bump with no parallelization properties. The parallel-safety-reviewer specialist task was not run, so this is not a clean result. I found no parallel-safety findings by static inspection of the diff.
Per-test assessment
No changed test methods were in scope (test_count = 0), so the result is Not applicable.
<sub>This advisory review is heuristic and non-blocking.
Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>
🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~27 AIC · ⌖ ~1 AIC · ⊞ 8.1K

Pull request
Summary
Update all six C#/Visual Basic Roslyn testing packages through their shared
MicrosoftCodeAnalysisAnalyzerTestingVersionproperty, and synchronize the separate native Bazel analyzer-test graph to 1.1.4.eng/bazel/tests-support/paket.lock, preview-package integrity metadata, andMODULE.bazel.lockwith the existing updater. The nine direct/transitive testing packages now resolve from nuget.org at 1.1.4; obsolete preview-feed integrity entries are removed.Microsoft.CodeAnalysis.*.Testinginto one Dependabot PR. The pattern matches exactly the six packages sharing this property.Design and decision record
This is dependency synchronization and grouping of packages that already share one version property, not a new product feature or API. A separate design record is unnecessary. It follows the existing native Roslyn pin policy. The supported Roslyn compiler baseline remains 4.14.0.
Demonstration
No UI or report-layout change; screenshots are not applicable. The actual executed native test layouts were inspected: the original dependency manifest lists all nine testing packages at
1.1.3-beta1.26255.1; the updated manifest lists all nine at1.1.4, with assembly versions1.1.4.0.Validation and regression proof
Compared original PR head
6206172593160eef74f2e42b875ebf8559d07c38with fixaf0b8bfd55ea8c02906b79c06ce22b60f0eb08de, using a separate detached checkout and isolated Bazel outputs for the original graph. Native tests used the repository-pinned Bazel/.NET toolchain,net10.0, win-x64, .NET runtime 10.0.14, and the unchanged method-parallel scheduling..\eng\bazel\tests-support\update-dependencies.ps1 -Resolve.\eng\bazel\tests-support\update-dependencies.ps1.\eng\bazel\verify-roslyn-dependencies.ps1 -SelfTestGet-Content .\.github\dependabot.yml -Raw | ConvertFrom-Yamlpowershell-yamlmodule; additionally checked the group against the six central package entries and confirmed other update scopes are unaffected.git diff HEAD^ HEAD --checkThe following exact focused command passed on both revisions, executing the same 50 existing
AvoidAssertAreEqualOnCollectionsAnalyzerTestsanalyzer/code-fix cases: Passed: 50, Failed: 0, Skipped: 0 on each graph. The selected identities were compared from the two TRX files.The unfiltered updated run used:
It built successfully, then returned Bazel exit 3: total 3,086; passed 3,069; failed 16; skipped 1. All 16 failing fixture identities also failed on the original PR head: ten
GlobalConfigGeneratorContinuationTestscases depend on missing native assembly/build-tool configuration, and six process-compatibility cases require the controlled-child entry point omitted by the existing native bootstrap. The original unfiltered comparison was stopped after reproducing these failures because that bootstrap launches recursive test children. A broad compound-filter retry still executed the child fixtures and was also stopped; neither interrupted run is counted as a completed baseline suite.The broad retry command was the unfiltered command above with
--test_arg=--filterand the single argument"--test_arg=FullyQualifiedName!~GlobalConfigGeneratorContinuationTests&FullyQualifiedName!~AnalyzerProcessCompatibilityTests&FullyQualifiedName!~AnalyzerCompatibilityTests.WaitForExit_OwnedChildCancellation_CompletesAndReleasesItsWait"appended. The final bounded, positive class filter above was verified from its TRX selection instead.Remaining gap: no clean unfiltered native-suite result is claimed. Full MSBuild/acceptance and shipping-package suites were not run; this change adds no product-code or API changes. Evidence logs/TRX files are retained locally and have not been uploaded:
native-analyzer-tests.log,updated-native-analyzer-tests.trx,baseline-native-unfiltered-partial.log,baseline-filtered-retry-partial.log,baseline-focused-analyzer-tests.trx,updated-focused-analyzer-tests.trx, andfocused-analyzer-comparison.json.Test-value evidence
Original Dependabot metadata
Updated Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing from 1.1.3-beta1.26255.1 to 1.1.4.
Release notes
Sourced from Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing's releases.
No release notes found for this version range.
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)