-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report diagnostics on unsupported auth #5496
base: main
Are you sure you want to change the base?
report diagnostics on unsupported auth #5496
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add some unit tests for this that tests that the diagnostic is reported as expected?
return { ApiKey: { Name: scheme.name } } as InputAuth; | ||
if (scheme.in !== "header") { | ||
Logger.getInstance().warn( | ||
`Only header is supported for ApiKey auth method. ${scheme.in} is not supported.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about: Only header is supported for ApiKey authentication. ${scheme.in} is not supported.
?
Fixes #5302
it works like this: