[python] always generate models with base init #5517
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:python
|
No changes needing a change description found. |
|
You can try these changes here
|
added 2 commits
January 7, 2025 17:20
…hon/generateInitAlways
dargilco
approved these changes
Jan 7, 2025
msyyc
reviewed
Jan 8, 2025
packages/http-client-python/generator/pygen/codegen/templates/model_dpg.py.jinja2
Outdated
Show resolved
Hide resolved
iscai-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
kristapratico
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have semi-complicated logic right now to determine whether we want to generate inits on our DPG models. This is to clean up the logic
See this teams convo for more context.