Ensure x-script's SHA is tolower'd. #1564
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large customer took a dependency on our happening to use lowercase SHA512s most of the time, and were broken when recent changes to vcpkgTools.xml contained capitalized SHA512s. This change always lowercases the SHA before invoking the x-script.
BillyONeal
commented
Jan 8, 2025
| @@ -82,7 +82,6 @@ namespace vcpkg | |||
| { | |||
| Checks::msg_exit_with_error(VCPKG_LINE_INFO, msgImproperShaLength, msg::value = *p); | |||
| } | |||
| Strings::inplace_ascii_to_lowercase(p->data(), p->data() + p->size()); | |||
There was a problem hiding this comment.
I think it's safe to make this change unconditionally because we already did it 99% of the time.
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jan 8, 2025
This is a 'quick and dirty workaround' for a customer who depended on our x-script SHAs in asset caching being lowercase. The real fix is microsoft/vcpkg-tool#1564 , but this is a change they can use before we can get a tool release out the door.
vicroms
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large customer took a dependency on our happening to use lowercase SHA512s most of the time, and were broken when recent changes to vcpkgTools.xml contained capitalized SHA512s. This change always lowercases the SHA before invoking the x-script.