Update to Docker contexts #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmarti
approved these changes
Aug 26, 2021
docs/remote/containers-advanced.md
Outdated
|
|
||
| Use the following command with the appropriate values to set up Docker on a remote SSH host. Note that you can use alternate [Docker Machine drivers](https://docs.docker.com/machine/drivers/) instead if you prefer. | ||
| You create new contexts with `docker context create`, specifying a name and endpoint configuration (cluster or single nodes): `docker context create my-context`. |
There was a problem hiding this comment.
Creating a context requires additional parameters. I'd link to Docker's documentation to avoid the complexity here: https://docs.docker.com/engine/context/working-with-contexts/
There was a problem hiding this comment.
Makes sense - added a hyperlink at the beginning of the section and removed some of the complexity here.
docs/remote/containers-advanced.md
Outdated
| docker-machine env give-it-a-name-here | Invoke-Expression | ||
| code | ||
| ``` | ||
| Without the Docker extension, Remote-Containers will use the current context. |
There was a problem hiding this comment.
Repeats the last sentence.
There was a problem hiding this comment.
Good catch! Removed last sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker contexts seem to be the newer concept compared to Docker Machine, so updating the documentation according to discussion
Fixes microsoft/vscode-remote-release#5403