Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Bumping eslint #2424

Merged
merged 2 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,015 changes: 301 additions & 714 deletions package-lock.json

Large diffs are not rendered by default.

13 changes: 6 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -693,21 +693,20 @@
"@types/fs-extra": "11.0.4",
"@types/jest": "29.5.13",
"@types/node": "22.5.4",
"@types/puppeteer-core": "5.4.0",
"@types/vscode": "1.93.0",
"@types/ws": "8.5.12",
"@typescript-eslint/eslint-plugin": "6.1.0",
"@typescript-eslint/parser": "6.1.0",
"@typescript-eslint/eslint-plugin": "8.5.0",
"@typescript-eslint/parser": "8.5.0",
"@vscode/vsce": "^3.1.0",
"copy-webpack-plugin": "12.0.2",
"eslint": "8.45.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jsdoc": "46.4.4",
"eslint": "8.57.1",
"eslint-plugin-import": "2.30.0",
"eslint-plugin-jsdoc": "50.2.3",
"eslint-plugin-prefer-arrow": "1.2.3",
"fs-extra": "11.2.0",
"jest": "29.7.0",
"ts-jest": " 29.2.5",
"ts-loader": "9.4.4",
"ts-loader": "9.5.1",
"typescript": "4.9.4",
"uglify-js": "3.19.3",
"unzipper": "0.12.3",
Expand Down
4 changes: 3 additions & 1 deletion src/cdpTargetsProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,13 @@ export class CDPTargetsProvider implements vscode.TreeDataProvider<CDPTarget> {
await fs.promises.writeFile(filePath, Buffer.concat(buffer));
actualTarget.faviconUrl = filePath;
resolve(actualTarget);
} catch (e) {
} catch {
// eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
reject(actualTarget);
}
});
} else {
// eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
resolve(actualTarget);
}
});
Expand Down
8 changes: 6 additions & 2 deletions src/devtoolsPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ export class DevToolsPanel {
if (!ScreencastPanel.instance && vscode.debug.activeDebugSession?.name.includes(providedHeadlessDebugConfig.name)) {
void vscode.commands.executeCommand('workbench.action.debug.stop');
}

// eslint-disable-next-line @typescript-eslint/no-unused-expressions
ScreencastPanel.instance && ScreencastPanel.instance.update();
}

Expand Down Expand Up @@ -210,7 +212,7 @@ export class DevToolsPanel {
void vscode.commands.executeCommand(`${SETTINGS_VIEW_NAME}.toggleInspect`, { enabled: true });
}
}
} catch (e) {
} catch {
// Ignore
}
}
Expand Down Expand Up @@ -446,7 +448,7 @@ export class DevToolsPanel {
const oldSourePath = sourcePath;
sourcePath = addEntrypointIfNeeded(sourcePath, this.config.defaultEntrypoint);
appendedEntryPoint = oldSourePath !== sourcePath;
} catch (e) {
} catch {
await ErrorReporter.showInformationDialog({
errorCode: ErrorCodes.Error,
title: 'Unable to open file in editor.',
Expand Down Expand Up @@ -576,6 +578,8 @@ export class DevToolsPanel {
});
panel.iconPath = vscode.Uri.joinPath(context.extensionUri, 'icon.png');
DevToolsPanel.instance = new DevToolsPanel(panel, context, telemetryReporter, targetUrl, config);

// eslint-disable-next-line @typescript-eslint/no-unused-expressions
ScreencastPanel.instance && ScreencastPanel.instance.update();
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/launchConfigManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class LaunchConfigManager {
for (const missingConfig of missingConfigs) {
configs.push((missingConfig as vscode.DebugConfiguration));
}
await launchJson.update('configurations', configs) as unknown as Promise<void>;
void await launchJson.update('configurations', configs);

// Add compound configs
let compounds = launchJson.get('compounds') as CompoundConfig[];
Expand All @@ -162,7 +162,7 @@ export class LaunchConfigManager {
for (const missingCompoundConfig of missingCompoundConfigs) {
compounds.push((missingCompoundConfig as CompoundConfig));
}
await launchJson.update('compounds', compounds) as unknown as Promise<void>;
void await launchJson.update('compounds', compounds);

// Insert instruction comment
let launchText = fse.readFileSync(workspaceUri.fsPath + relativePath).toString();
Expand Down
2 changes: 1 addition & 1 deletion src/launchDebugProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export class LaunchDebugProvider implements vscode.DebugConfigurationProvider {
}
} else {
this.telemetryReporter.sendTelemetryEvent('debug/error/config_not_found');
vscode.window.showErrorMessage('No supported launch config was found.') as Promise<void>;
void vscode.window.showErrorMessage('No supported launch config was found.');
}

return undefined;
Expand Down
2 changes: 1 addition & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export async function getListOfTargets(hostname: string, port: number, useHttps:
if (jsonResponse) {
break;
}
} catch (e) {
} catch {
// localhost might not be ready as the user might not have a server running
// user may also have changed settings making the endpoint invalid
}
Expand Down
Loading