Skip to content

Commit

Permalink
removing line height from renderLineInput
Browse files Browse the repository at this point in the history
  • Loading branch information
aiday-mar committed Jan 9, 2025
1 parent cdf8764 commit 6ead1c3
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/vs/editor/common/viewLayout/viewLineRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export class RenderLineInput {
public readonly renderWhitespace: RenderWhitespace;
public readonly renderControlCharacters: boolean;
public readonly fontLigatures: boolean;
public readonly lineHeight: number;

/**
* Defined only when renderWhitespace is 'selection'. Selections are non-overlapping,
Expand All @@ -89,8 +88,7 @@ export class RenderLineInput {
renderWhitespace: 'none' | 'boundary' | 'selection' | 'trailing' | 'all',
renderControlCharacters: boolean,
fontLigatures: boolean,
selectionsOnLine: LineRange[] | null,
lineHeight: number
selectionsOnLine: LineRange[] | null
) {
this.useMonospaceOptimizations = useMonospaceOptimizations;
this.canUseHalfwidthRightwardsArrow = canUseHalfwidthRightwardsArrow;
Expand Down Expand Up @@ -119,7 +117,6 @@ export class RenderLineInput {
this.renderControlCharacters = renderControlCharacters;
this.fontLigatures = fontLigatures;
this.selectionsOnLine = selectionsOnLine && selectionsOnLine.sort((a, b) => a.startOffset < b.startOffset ? -1 : 1);
this.lineHeight = lineHeight;

const wsmiddotDiff = Math.abs(wsmiddotWidth - spaceWidth);
const middotDiff = Math.abs(middotWidth - spaceWidth);
Expand Down Expand Up @@ -175,7 +172,6 @@ export class RenderLineInput {
&& LineDecoration.equalsArr(this.lineDecorations, other.lineDecorations)
&& this.lineTokens.equals(other.lineTokens)
&& this.sameSelection(other.selectionsOnLine)
&& this.lineHeight === other.lineHeight
);
}
}
Expand Down

0 comments on commit 6ead1c3

Please sign in to comment.