build: enable pylint E and F rule classes

.github/workflows/python-build.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.11", "3.12"]
-        os: ["windows-latest", "ubuntu-latest", "macos-latest"]
+        os: ["windows-latest", "ubuntu-latest"]
     env:
       SKIP: no-commit-to-branch
     steps:

.pre-commit-config.yaml

@@ -7,7 +7,7 @@ ci:
   autofix_commit_msg: "chore(pre-commit.ci): auto fixes"
   autoupdate_commit_msg: "chore(pre-commit.ci): pre-commit autoupdate"
   autoupdate_schedule: weekly
-  skip: [mypy]
+  skip: [mypy, pylint]
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
@@ -56,3 +56,14 @@ repos:
         entry: mypy
         language: system
         types: [python]
+      - id: pylint
+        name: pylint
+        entry: pylint
+        language: system
+        types: [python]
+        args: [
+            "-rn", # Only display messages
+            "-sn", # Don't display the score
+            "--rcfile=pylintrc",
+            "--ignore-paths=tests",
+          ]

midealocal/device.py

@@ -228,7 +228,7 @@ def connect(
             file = None
             lineno = None
             if e.__traceback__:
-                file = e.__traceback__.tb_frame.f_globals["__file__"]
+                file = e.__traceback__.tb_frame.f_globals["__file__"]  # pylint: disable=E1101
                 lineno = e.__traceback__.tb_lineno
             _LOGGER.exception(
                 "[%s] Unknown error : %s, %s",
@@ -555,7 +555,7 @@ def run(self) -> None:
                     file = None
                     lineno = None
                     if e.__traceback__:
-                        file = e.__traceback__.tb_frame.f_globals["__file__"]
+                        file = e.__traceback__.tb_frame.f_globals["__file__"]  # pylint: disable=E1101
                         lineno = e.__traceback__.tb_lineno
                     _LOGGER.exception(
                         "[%s] Unknown error : %s, %s",

midealocal/devices/ac/message.py

@@ -574,8 +574,8 @@ def _body(self) -> bytearray:
             )
         if self.fresh_air_1 is not None and len(self.fresh_air_1) == FRESH_AIR_LENGTH:
             pack_count += 1
-            fresh_air_power = 2 if self.fresh_air_1[0] > 0 else 1
-            fresh_air_fan_speed = self.fresh_air_1[1]
+            fresh_air_power = 2 if next(iter(self.fresh_air_1)) > 0 else 1
+            fresh_air_fan_speed = list(self.fresh_air_1)[1]
             payload.extend(
                 NewProtocolMessageBody.pack(
                     param=NewProtocolTags.fresh_air_1,
@@ -597,8 +597,8 @@ def _body(self) -> bytearray:
             )
         if self.fresh_air_2 is not None and len(self.fresh_air_2) == FRESH_AIR_LENGTH:
             pack_count += 1
-            fresh_air_power = 1 if self.fresh_air_2[0] > 0 else 0
-            fresh_air_fan_speed = self.fresh_air_2[1]
+            fresh_air_power = 1 if next(iter(self.fresh_air_2)) > 0 else 0
+            fresh_air_fan_speed = list(self.fresh_air_2)[1]
             payload.extend(
                 NewProtocolMessageBody.pack(
                     param=NewProtocolTags.fresh_air_2,