fix(cloud): get default keys as static

[rokam]

Summary by CodeRabbit

• Refactor
  • Changed get_default_keys methods in the Cloud class to static methods for improved code structure and behavior consistency.

[coderabbitai]

Walkthrough

The Cloud class in midealocal/cloud.py has been updated to modify two of its methods, login and get_default_keys, converting them into static methods. This change alters how these methods are accessed and used within the class but does not introduce any new features or control flows.

Changes

File	Change Summary
midealocal/cloud.py	Converted the login and get_default_keys methods in the Cloud class to static methods.

Poem

In the cloud where bytes do soar,
Static methods open doors,
Login shifts, keys align,
Code refined, oh how divine!
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.95%. Comparing base (556f7c2) to head (c3faf6b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   35.94%   35.95%           
=======================================
  Files          81       81           
  Lines        7063     7064    +1     
=======================================
+ Hits         2539     2540    +1     
  Misses       4524     4524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

midealocal/cloud.py (1)

216-217: Update method calls to use the class name MideaCloud instead of an instance.

The conversion of get_default_keys to a static method requires updating the following instances where the method is called on an instance:

• tests/cloud_test.py
  • Line: keys = await cloud.get_default_keys()
• tests/cli_test.py
  • Line: mock_cloud_instance.get_default_keys.return_value = {
• midealocal/cli.py
  • Line: default_keys = await cloud.get_default_keys()

Please update these calls to use MideaCloud.get_default_keys() instead.

Analysis chain

Approved change to static method. Verify usage across the codebase.

The conversion of get_default_keys to a static method is appropriate as it does not depend on instance variables.

Ensure that all calls to this method are updated to use the class name instead of an instance.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all calls to `get_default_keys` use the class name.

# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg --type python -A 5 $'MideaCloud.get_default_keys'

Length of output: 82

---

Script:

#!/bin/bash
# Description: Verify all calls to `get_default_keys` use the class name.

# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg 'get_default_keys' -A 5

Length of output: 1377

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 556f7c2 and c3faf6b.

Files selected for processing (1)

• midealocal/cloud.py (1 hunks)

[chemelli74]

I see a change only in default keys