revert: segregate connect/auth/refresh/enable device duties #242
Conversation
…)" This reverts commit 681bd79.
WalkthroughThe recent changes enhance the device connection and authentication processes by simplifying the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
rokam
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- midealocal/device.py (5 hunks)
- midealocal/exceptions.py (1 hunks)
- tests/device_test.py (3 hunks)
Files skipped from review due to trivial changes (1)
- midealocal/exceptions.py
Additional comments not posted (31)
tests/device_test.py (17)
Line range hint
31-48:
LGTM!The
_setup_devicefixture correctly initializes theMideaDeviceinstance.
Line range hint
50-60:
LGTM!The
test_initial_attributesfunction correctly verifies the initial state of the device attributes.
62-103: LGTM!The
test_connectfunction comprehensively tests the connection logic, including exception handling and verifying the device's availability state.
105-111: LGTM!The
test_connect_generic_exceptionfunction correctly handles a generic exception during the connection attempt and verifies the device's availability state.
Line range hint
113-139:
LGTM!The
test_authenticatefunction comprehensively tests the authentication logic, including handling socket exceptions and authentication failures.
Line range hint
141-161:
LGTM!The
test_send_messagefunction comprehensively tests the message sending logic, including handling different protocol versions.
Line range hint
163-174:
LGTM!The
test_get_capabilitiesfunction correctly verifies the device's capability querying logic.
Line range hint
176-202:
LGTM!The
test_refresh_statusfunction comprehensively tests the device's status refreshing logic, including handling different exceptions.
Line range hint
204-242:
LGTM!The
test_parse_messagefunction comprehensively tests the message parsing logic, including handling different message types.
Line range hint
244-253:
LGTM!The
test_pre_process_messagefunction correctly verifies the pre-processing logic of the device's messages.
Line range hint
255-259:
LGTM!The
test_process_messagefunction correctly raises aNotImplementedErroras expected.
Line range hint
261-267:
LGTM!The
test_send_commandfunction correctly verifies the command sending logic, including handling exceptions.
Line range hint
269-272:
LGTM!The
test_send_heartbeatfunction correctly verifies the heartbeat sending logic.
Line range hint
274-282:
LGTM!The
test_register_updatefunction correctly verifies the update registration logic.
Line range hint
284-291:
LGTM!The
test_openfunction correctly verifies the open logic of the device.
Line range hint
293-299:
LGTM!The
test_closefunction correctly verifies the close logic of the device.
Line range hint
301-309:
LGTM!The
test_set_ipfunction correctly verifies the IP address setting logic.midealocal/device.py (14)
142-143: LGTM!The
_availableattribute is now initialized toTrue, indicating that the device is available upon initialization.
193-239: LGTM!The
connectmethod has been refactored to accept two new parameters:refresh_statusandget_capabilities. The connection logic has been simplified, and error handling has been improved.
241-252: LGTM!The
authenticatemethod correctly handles the authentication logic for the device.
Line range hint
254-261:
LGTM!The
send_messagemethod correctly handles the message sending logic for different protocol versions.
Line range hint
263-274:
LGTM!The
send_message_v2method correctly handles the message sending logic for protocol version 2.
Line range hint
276-282:
LGTM!The
send_message_v3method correctly handles the message sending logic for protocol version 3.
Line range hint
284-290:
LGTM!The
build_sendmethod correctly handles the serialization and sending of commands.
Line range hint
292-297:
LGTM!The
get_capabilitiesmethod correctly handles the capability querying logic.
Line range hint
299-356:
LGTM!The
refresh_statusmethod correctly handles the status refreshing logic, including handling different exceptions.
Line range hint
358-372:
LGTM!The
pre_process_messagemethod correctly handles the pre-processing logic.
Line range hint
374-450:
LGTM!The
parse_messagemethod correctly handles the message parsing logic, including handling different message types.
Line range hint
452-454:
LGTM!The
build_querymethod correctly raises aNotImplementedErroras expected.
Line range hint
456-458:
LGTM!The
capabilities_querymethod correctly handles the capability querying logic.
Line range hint
460-462:
LGTM!The
process_messagemethod correctly raises aNotImplementedErroras expected.
Reverts #233
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Chores