Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typing part 1 #26

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

chemelli74
Copy link
Member

Started introducing typing in the library.

  • discover.py
  • security.py

@chemelli74 chemelli74 requested a review from rokam May 27, 2024 12:12
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.03774% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 4.13%. Comparing base (c8bc516) to head (e2be518).
Report is 1 commits behind head on main.

Files Patch % Lines
midealocal/security.py 77.77% 10 Missing ⚠️
midealocal/discover.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #26      +/-   ##
========================================
+ Coverage   4.10%   4.13%   +0.02%     
========================================
  Files         77      77              
  Lines       6571    6577       +6     
========================================
+ Hits         270     272       +2     
- Misses      6301    6305       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokam rokam merged commit 1992fdd into midea-lan:main May 27, 2024
3 checks passed
@chemelli74 chemelli74 deleted the chemelli74-typing-1 branch May 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants