fix(c3): silent typo

[rokam]

Summary by CodeRabbit

• New Features

  • Introduced a new class variable in the MideaC3Device to provide structured access to silent modes, enhancing usability.
  • Updated terminology for clarity by renaming silence_mode to silent_mode and silence_level to silent_level.

• Tests

  • Adjusted test cases to reflect the new attribute names for consistency and clarity.
  • Added verification to ensure the silent_modes attribute is initialized correctly with the expected number of modes.

[coderabbitai]

Walkthrough

The recent changes improve clarity in attribute naming within the C3QuerySilenceMessageBody and MessageC3Response classes, where silence_mode and silence_level have been renamed to silent_mode and silent_level. Additionally, the MideaC3Device class introduces a new class variable _silent_modes for better management of silent states. Overall, these modifications enhance code intuitiveness while maintaining existing functionality.

Changes

Files	Change Summary
midealocal/devices/c3/message.py and tests/devices/c3/message_c3_test.py	Renamed attributes silence_mode to silent_mode and silence_level to silent_level. Updated assertions in tests accordingly; logic remains unchanged.
midealocal/devices/c3/__init__.py	Introduced a new class variable _silent_modes in MideaC3Device for clearer management of silent levels. Modified set_attribute to accept string inputs for silent levels.
tests/devices/c3/device_c3_test.py	Added assertion in test_initial_attributes to check length of silent_modes. Updated argument in test_set_attribute to use C3SilentLevel.SILENT.name.

Poem

🐇 In the code where silence dwells,
A hop, a change, new names it tells.
Silent_mode now takes the stage,
Clarity blooms on every page.
With levels set, the message flows,
In harmony, the logic grows! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e40581 and b1a244d.

Files selected for processing (2)

• midealocal/devices/c3/message.py (1 hunks)
• tests/devices/c3/message_c3_test.py (1 hunks)

Files skipped from review due to trivial changes (2)

• midealocal/devices/c3/message.py
• tests/devices/c3/message_c3_test.py

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.65%. Comparing base (2e40581) to head (445c24f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   37.61%   37.65%   +0.03%     
==========================================
  Files          84       84              
  Lines        7454     7458       +4     
==========================================
+ Hits         2804     2808       +4     
  Misses       4650     4650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b1a244d and 1e102f5.

Files selected for processing (1)

• midealocal/devices/c3/init.py (2 hunks)

Additional comments not posted (1)

midealocal/devices/c3/__init__.py (1)

26-30: LGTM! The new class variable _silent_modes improves code clarity and usability.

The addition of _silent_modes provides a structured way to access the silent modes associated with the device, enhancing the functionality of the MideaC3Device class.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1e102f5 and 445c24f.

Files selected for processing (2)

• midealocal/devices/c3/init.py (4 hunks)
• tests/devices/c3/device_c3_test.py (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• midealocal/devices/c3/init.py

Additional comments not posted (2)

tests/devices/c3/device_c3_test.py (2)

93-93: Good addition for verifying silent_modes.

The assertion checking the length of silent_modes enhances the test coverage by ensuring the attribute is initialized correctly.

---

112-113: Verify the use of .name for enum C3SilentLevel.SILENT.

The change from C3SilentLevel.SILENT to C3SilentLevel.SILENT.name affects how the attribute is set. Ensure that set_attribute handles enum names correctly.

[chemelli74]

LGTM !