Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typing part 2 #27

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

chemelli74
Copy link
Member

Started introducing typing in the library.

  • cloud.py
  • packet_builder.py

@chemelli74 chemelli74 requested a review from rokam May 27, 2024 13:29
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 5.33%. Comparing base (1992fdd) to head (2900602).

Files Patch % Lines
midealocal/packet_builder.py 0.00% 8 Missing ⚠️
midealocal/cloud.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #27      +/-   ##
========================================
+ Coverage   5.32%   5.33%   +0.01%     
========================================
  Files         77      77              
  Lines       6577    6579       +2     
========================================
+ Hits         350     351       +1     
- Misses      6227    6228       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chemelli74 chemelli74 force-pushed the chemelli74-typing-2 branch from 69e9d94 to 2900602 Compare May 27, 2024 13:32
@rokam rokam merged commit b6469c5 into midea-lan:main May 27, 2024
3 checks passed
@chemelli74 chemelli74 deleted the chemelli74-typing-2 branch May 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants