Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ed): add all query msg for 0xED device #328

Merged
merged 5 commits into from
Dec 24, 2024
Merged

feat(ed): add all query msg for 0xED device #328

merged 5 commits into from
Dec 24, 2024

Conversation

wuwentao
Copy link
Member

@wuwentao wuwentao commented Oct 16, 2024 •
edited
Loading

@wuwentao wuwentao requested a review from rokam October 16, 2024 09:07
@github-actions github-actions bot added the enhancement New feature or request label Oct 16, 2024
rokam
rokam previously requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to create another class and not to use the body_type parameter?
I prefer that you create the query message twice each one with a different body type.

@wuwentao
Copy link
Member Author

@rokam please check the source code from device.py with refresh_status steps.
it can't work anymore

@wuwentao wuwentao dismissed rokam’s stale review October 17, 2024 04:31

it can't works

rokam
rokam suggested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it with suggestions to be clear. It will work.

midealocal/devices/ed/__init__.py Show resolved Hide resolved
midealocal/devices/ed/__init__.py Show resolved Hide resolved
tests/devices/ed/device_ed_test.py Show resolved Hide resolved
tests/devices/ed/message_ed_test.py Show resolved Hide resolved
midealocal/devices/ed/message.py Show resolved Hide resolved
rokam
rokam suggested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, self._device_class = ListTypes.X00 isn't needed anymore.

midealocal/devices/ed/__init__.py Outdated Show resolved Hide resolved
@wuwentao wuwentao mentioned this pull request Dec 19, 2024
Closed
@wuwentao wuwentao added this to the v6.0.4 milestone Dec 19, 2024
@wuwentao wuwentao changed the title feat(ed): add new query01 msg for ed device feat(ed): add all query msg for 0xED device Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
midealocal/devices/ed/__init__.py 96.00% <100.00%> (ø)
midealocal/devices/ed/message.py 95.50% <100.00%> (+1.38%) ⬆️

@wuwentao wuwentao merged commit 30ba082 into main Dec 24, 2024
10 checks passed
@wuwentao wuwentao deleted the add_ed_query branch December 24, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokam rokam rokam requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v6.0.4
2 participants
@wuwentao @rokam