-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Refactor Load Types #2241
Open
mikedh
wants to merge
42
commits into
main
Choose a base branch
from
refactor/loadtype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 3, 2024
Updated use of weights in procrustes analysis (update to #1647)
Fix nearest.ipynb Typo
[BUG] fix rounding issue in uv_to_color()
Release: Procrustes Weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very common source of annoyance and confusion is that
trimesh.load
can return lots of different types (this fixes #2239, etc). This re-factor changes the return types to:trimesh.load -> Geometry
load_scene
but with a mapping of what the old function used to do, and a deprecation warning saying you should useload_scene
.trimesh.load_scene -> Scene
trimesh.load_mesh -> Trimesh
trimesh.load(..., force='mesh')
will be deprecated in favor ofload_mesh
trimesh.load_path -> Path
Path2D
orPath3D
which both inherit but is still a little outside the spirit of "functions should return the same type always." Maybe aforce_dimension
argument could be here.Additional changes: