Skip to content

Use lazy fields accessor for empty header operations #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Use lazy fields accessor for empty header operations #1672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Code Improvements:

Bug Fixes:

* Use lazy fields accessor for empty header operations @OskarEichler

* Regression: Preserve message-level charset when adding parts (related to Rails ActionMailer) @shields
* Regression: Adding a part should not reset the mail's charset to nil @railsbob

Expand Down
4 changes: 2 additions & 2 deletions lib/mail/header.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def initialize(header_text = nil, charset = nil)

def initialize_copy(original)
super
@fields = @fields.dup
@fields = fields.dup
@fields.map!(&:dup)
end

Expand Down Expand Up @@ -103,7 +103,7 @@ def fields=(unfolded_fields)
end

def errors
@fields.map(&:errors).flatten(1)
fields.map(&:errors).flatten(1)
end

# 3.6. Field definitions
Expand Down