Parse escaped chars #2
Conversation
|
I've added some suggestions, and please add some tests for each of the scenarios and edge cases please |
|
I added a test for results in
What do you mean? I can't see any comments or changes on the code. |
… \t, \r chars to test
They're comments on the code made on this pull request, see here: #2 |
|
I'm sorry but I can't see any comments. |
| @@ -596,7 +596,29 @@ open class JSON { | |||
| } | |||
| } | |||
|
|
|||
| let parsedString = String(jsonString[startingIndex ..< index]) | |||
| var parsedString = String(jsonString[startingIndex ..< index]) | |||
There was a problem hiding this comment.
This could stay as a constant and be given a different name and built upon, e.g.
let initialParsedString = String()
let parsedString = initialParsedString.someOperation()
There was a problem hiding this comment.
I'm not sure if this is useful. I mean how would you implement this for the hexEncodedUnicodeCharRegex parsedString? Feel free to push your solution on this branch.
Hi! First of all, thanks for this library!
I noticed that it does not parse escaped chars like
\nor\u00fc(ü), see here.This change adds support for those escaped values.