[Feat] Add a verbose option for json_schema_converter (#97)

This PR provides a verbose option for json_schema_converter.
mlc-ai · Nov 25, 2024 · bea9cbc · bea9cbc
1 parent 566455c
commit bea9cbc
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/cpp/json_schema_converter.cc b/cpp/json_schema_converter.cc
@@ -158,12 +158,12 @@ class JSONSchemaConverter {
 
   /*! \brief Warn if any keyword is existing in the schema but not supported. */
   static void WarnUnsupportedKeywords(
-      const picojson::value& schema, const std::vector<std::string>& keywords
+      const picojson::value& schema, const std::vector<std::string>& keywords, bool verbose = false
   );
 
   /*! \brief Warn if any keyword is existing in the object but not supported. */
   static void WarnUnsupportedKeywords(
-      const picojson::object& schema, const std::vector<std::string>& keywords
+      const picojson::object& schema, const std::vector<std::string>& keywords, bool verbose = false
   );
 
   /*! \brief Visit the schema and return the rule body for later constructing the rule. */
@@ -417,19 +417,22 @@ std::string JSONSchemaConverter::NextSeparator(bool is_end) {
 }
 
 void JSONSchemaConverter::WarnUnsupportedKeywords(
-    const picojson::value& schema, const std::vector<std::string>& keywords
+    const picojson::value& schema, const std::vector<std::string>& keywords, bool verbose
 ) {
   if (schema.is<bool>()) {
     return;
   }
 
   XGRAMMAR_DCHECK(schema.is<picojson::object>());
-  WarnUnsupportedKeywords(schema.get<picojson::object>(), keywords);
+  WarnUnsupportedKeywords(schema.get<picojson::object>(), keywords, verbose);
 }
 
 void JSONSchemaConverter::WarnUnsupportedKeywords(
-    const picojson::object& schema, const std::vector<std::string>& keywords
+    const picojson::object& schema, const std::vector<std::string>& keywords, bool verbose
 ) {
+  if (!verbose) {
+    return;
+  }
   for (const auto& keyword : keywords) {
     if (schema.find(keyword) != schema.end()) {
       XGRAMMAR_LOG(WARNING) << "Keyword " << keyword << " is not supported in schema "