code cleanup: C cast not required anymore as _cmsGetTransformFlags(struct _cmstransform_struct* CMMcargo) already matches the incoming type.
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… C++) mode: this uncovered a few unneccessary casts and required a few others (void pointer conversions). # Conflicts: # include/lcms2.h # include/lcms2_plugin.h # plugins/fast_float/src/fast_16_tethra.c # plugins/fast_float/src/fast_8_curves.c # plugins/fast_float/src/fast_8_matsh.c # plugins/fast_float/src/fast_8_matsh_sse.c # plugins/fast_float/src/fast_8_tethra.c # plugins/fast_float/src/fast_float_15mats.c # plugins/fast_float/src/fast_float_cmyk.c # plugins/fast_float/src/fast_float_curves.c # plugins/fast_float/src/fast_float_lab.c # plugins/fast_float/src/fast_float_matsh.c # plugins/fast_float/src/fast_float_tethra.c # plugins/threaded/src/threaded_internal.h # plugins/threaded/src/threaded_scheduler.c # src/cmscgats.c # src/cmstypes.c # src/cmsxform.c # src/extra_xform.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bit that showed during 'pedantic warning mode' MSVC build…
This does away with a C type cast which is not required any more as the variable's type matches the function argument / prototype exactly already without it. No functional change, just a bit of cleanup.
🙏 please forgive the shoddy commit message for this one as that's a straight (edited) cherry-pick off another branch of mine, which tracks lcms2mt. It's crud and this PR description is overriding. 🙏