Fix flaky --exit integration timeout by avoiding a hard-coded port - #6364
Draft
mark-wiemer with Copilot wants to merge 2 commits into
Draft
mark-wiemer with Copilot wants to merge 2 commits into
mark-wiemer with Copilot wants to merge 2 commits into
Conversation
|
5 tasks
Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flaky test: ensure exit does not happen after root suite completion
Fix flaky Sep 19, 2026
--exit integration timeout by avoiding a hard-coded port
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--exitintegration spec was intermittently failing because the test fixture bound a fixed local port. Under CI and busy environments, that can collide with other listeners or stale processes and make the “should hang when--no-exitis used” case fail even though the root suite behavior is correct.server.listen(0, done);--no-exitbehavior is in effect, without depending on a port that may already be in use.This keeps the test focused on the actual behavior under test and removes the flaky dependency on local port availability.