-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nit: Add ListResourceTemplates
to ClientRequest
/ ServerResult
in schema.ts
#120
Conversation
ListResourceTemplatesResult
to ServerResult
in schema.tsListResourceTemplates
to ClientRequest
/ ServerResult
in schema.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, great catch. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsabran Can you please just run npm run generate:json
to update the JSON Schema? Then we can get this in. 🙏
Ah yes I'll do |
Side question: do you think there's a need to clarify the results for There is no |
This might also be an oversight on our end. |
Based on my understanding of the specs, it seems that those values were forgotten in the
ClientRequest
/ServerResult
type.Motivation and Context
This change aligns
schema.ts
with the description of the specs found in https://spec.modelcontextprotocol.io/specification/server/resources/How Has This Been Tested?
NA
Breaking Changes
Possibly breaking Typescript compilation for developers referencing
ClientRequest
/ServerResult
. Still mostly a bug fix.Types of changes
Checklist