-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional 'size' field to the Resource type. #132
Open
evalstate
wants to merge
5
commits into
modelcontextprotocol:main
Choose a base branch
from
evalstate:feature/resource-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add an optional 'size' field to the Resource type. #132
evalstate
wants to merge
5
commits into
modelcontextprotocol:main
from
evalstate:feature/resource-size
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalstate
changed the title
Feature/resource size
Add an optional 'size' field to the Resource type.
Jan 7, 2025
jspahrsummers
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a great idea! Just one wording nit, but I'm happy with this.
Tagging in @dsp-ant for second approval.
Improved wording Co-authored-by: Justin Spahr-Summers <[email protected]>
jspahrsummers
approved these changes
Jan 10, 2025
dsp-ant
approved these changes
Jan 10, 2025
This needs to rebased to be moved into draft |
@dsp-ant This is backwards compatible, so I think it can be additive to the last release, no? |
jerome3o-anthropic
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional 'size' field to the Resource type. The 'size' represents the raw size in bytes (before encoding or tokenization).
This can be used by the Client/Host Application to pre-emptively estimate Context Window usage and make informed decisions about resource handling before attempting to load or process resources.
Motivation and Context
When working with LLMs, it's crucial to manage context window limitations effectively. This addition allows Host/Client applications to make smarter decisions about resource handling before attempting to process them.
For example:
How Has This Been Tested?
Schema change only - no runtime implications to test. SDK implementations will need their own testing coverage when incorporating this field.
Breaking Changes
No breaking changes:
Types of changes
Checklist
Additional context
This change aligns with common patterns in file system and storage APIs where size information is readily available. It provides valuable metadata for client applications while maintaining backward compatibility.
The size field specifically represents raw byte size to avoid confusion with token counts or other encoded sizes. This distinction is documented in the schema comments to prevent misuse.