-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add cjs format support #110
fix: add cjs format support #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to inline every file's imports into the output version of that file (CJS and ESM).
If you can fix that up—so that cross-file imports/requires work as expected—we can consider pulling this in.
If not, note that CJS support is not a priority for us.
I’ve updated the code. Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! I checked out this out locally and took it for a spin, and it looks pretty reasonable to me.
I'm going to merge this, and let it sit on main
for a bit while folks give it a try—just to make sure there are no unexpected issues—then push a new package release later.
Close #90