Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cjs format support #110

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Dec 31, 2024

Close #90

image

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to inline every file's imports into the output version of that file (CJS and ESM).

If you can fix that up—so that cross-file imports/requires work as expected—we can consider pulling this in.

If not, note that CJS support is not a priority for us.

@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Jan 3, 2025

fix

I’ve updated the code. Please review it again.

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I checked out this out locally and took it for a spin, and it looks pretty reasonable to me.

I'm going to merge this, and let it sit on main for a bit while folks give it a try—just to make sure there are no unexpected issues—then push a new package release later.

@jspahrsummers jspahrsummers merged commit 29d08ff into modelcontextprotocol:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonJS Support
2 participants