Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate notification params #98

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

jerome3o-anthropic
Copy link
Contributor

Model Context Protocol SDK: Pass through progress params

Motivation and Context

Support additional fields in progress notifications beyond just progress and total by passing through all notification parameters to handlers.

How Has This Been Tested?

Verified through existing protocol tests and usage scenarios requiring extended progress information.

Breaking Changes

None. Maintains backward compatibility while enabling additional progress parameters.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Modified _onprogress to only extract progressToken and pass remaining params through to handlers. Version bump 1.0.3 → 1.0.4.

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startrekapproved

@jerome3o-anthropic jerome3o-anthropic merged commit 422a535 into main Dec 16, 2024
4 checks passed
@jerome3o-anthropic jerome3o-anthropic deleted the jerome/fix/propagate-notification-params branch December 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants