Conversation
LauraGPT
left a comment
There was a problem hiding this comment.
Rechecked exact head ad11daa against base 9e72061. The three submitted CLI-switch tests plus seven existing recognition-result compatibility tests pass (10 total). Running the same three new tests on the unchanged base gives one expected assertion failure: parsed --sd_switch yes requests no speaker results; the no/default and existing Yes/No controls pass.
The tested candidate now forwards return_spk_res=True for lowercase yes, retains False for no/default, and preserves the existing UI Yes/No behavior. I loaded the hash-verified candidate module under both videoclipper import names with unchanged base helpers and real CPU numerical dependencies. The ASR boundary is a recorder stand-in: this verifies parser-to-recog option routing and state behavior, not model diarization accuracy, a full CLI subprocess, or browser/video export.
No new functional blocker was found in this bounded check. Please replace the TODO PR template with the issue54 scope and these validation steps before merging. This review does not close issue54 or establish full workflow acceptance.
|
Hi maintainers, the GitHub Actions workflow for this PR is currently awaiting maintainer approval, so no CI jobs have run yet. Could you please approve the workflow when convenient? Thank you! |
Summary
Fix CLI speaker diarization switch handling so that the documented lowercase value:
--sd_switch yesactually enables speaker diarization.
Previously, the CLI accepted lowercase
yes/no, while the runtime logic only treated"Yes"as enabled. As a result, using--sd_switch yescould silently leave speaker diarization disabled.Changes
sd_switchhandling case-insensitive.--sd_switch yesenables speaker diarization.--sd_switch nokeeps it disabled.Yes/Novalues.Validation
Regression coverage includes:
yesnoYes/NoUI compatibilityThe focused validation reported 10/10 relevant tests passing (3 new regression tests + 7 existing compatibility tests).
This validation is scoped to the switch-handling regression and does not claim full end-to-end diarization, browser, or video export validation.
Fixes #54