-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposition of API for the method network % evaluate
#182
Conversation
I added example use of this to examples/dense_mnist.f90. One challenge I found is that if we use the multiple metrics variant, we can't mix and match functions defined in I think there may be a workaround by first staging metrics as Even if it can't be done, it's a minor limitation IMO. I'll add some tests too. |
@jvdp1 actually, my challenge I mentioned above extends to even passing multiple metrics of the same parent type. Can you show me one example of invoking |
I think once we add one example of passing multiple metrics (say, in a test program), we can merge this PR. |
Indeed, you are right. The same problem happens also with multiple metrics of the same parent type. So, it seems that |
A possible solution could be this one proposed by Brad. But it sounds to me a bit too complex for what we want to achieve. |
Yes, I think this is the same approach that we use to pass an array of heterogeneous layers to a network. It's also overkill for the user to do this. Let's remove the multi-metrics variant then, at least until we hear anyone really needing this. |
Thank you! |
Related to #179