Repository navigation
fix(Combobox): Chevron interactivity - #7975
Open
logiczsniper wants to merge 1 commit into
Open
logiczsniper wants to merge 1 commit into
logiczsniper wants to merge 1 commit into
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7927
handleSearchFocusouthandler from executing, which would cause another bug wherein clicking the chevron to close the dropdown would cause it to close (due tohandleSearchFocusout) and then immediately re-open as the newhandleSearchIconClickis calledhandleSearchIconClickhandler to enable opening and closing on click of the chevronNote
This is my first PR in this repo - my first PR writing Vue in years 😅 and I don't see any test files... please lemme know if you wanna see anything else here 🙌