Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] fix: license check ci #3933

Closed
wants to merge 1 commit into from
Closed

[stdlib] fix: license check ci #3933

wants to merge 1 commit into from

Conversation

sstadick
Copy link

@sstadick sstadick commented Jan 8, 2025

@sstadick
fix: convert license var to a string
06ae792 
Possibly broken by modularml@4903cf9

Signed-off-by: Seth Stadick <[email protected]>
@sstadick sstadick mentioned this pull request Jan 8, 2025
Open
@sstadick sstadick marked this pull request as ready for review January 8, 2025 14:23
@sstadick sstadick requested a review from a team as a code owner January 8, 2025 14:23
@martinvuyk
Copy link
Contributor

I'd rather have PR #3922 merged which avoids allocations and solves this issue

@sstadick
Copy link
Author

sstadick commented Jan 8, 2025

That's a better fix. I didn't realize it fixed the same issue. Closing i favor of #3922

@sstadick sstadick closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sstadick @martinvuyk