Repository navigation
Conversation
The channel commands need the channel RPCs in the api fork and a server that serves them. The server fork's go.mod forces Go 1.27, nexus-rpc v0.7.0 and the sdk v1.48.0.
2 of 3 tasks
Owner
Author
|
Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the server and api forks that serve the notification channel, plus what the pins force.
What changed?
go.modreplacesgo.temporal.io/serverwithgithub.com/moetemp/temporalat the top of the channel server chain.go.modreplacesgo.temporal.io/apiwithgithub.com/moetemp/api-goat the channel api head.nexus-rpc/sdk-goto v0.7.0 andgo.temporal.io/sdkto v1.48.0.Part of AI-198 (epic AI-37).
Why?
Nothing here is a feature. The channel commands in the next PR need the channel RPCs from the api fork and a server that serves them in
start-dev. You can't take the api alone, since the stock server stops compiling onceWorkflowServiceClientgains the channel methods. The server fork already requires the newer Go, nexus and sdk, sogo mod tidylifts them with the pin. Therequireline for the server stays on the tagged release, so the server version check still passes.How did you test it?
Link to a test plan if any -
go build ./...passes on the pins with no CLI change, andgo mod tidyleaves both modules as they are. The next PR runs the suites on this pin.