Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update broken links in readme file #1477

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

garysassano
Copy link
Contributor

No description provided.

Copy link
Contributor

@anitarua anitarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for contributing to our repo!

Nice catch on these broken links. Do you mind fixing them in the readme template instead, though?
Our readme generator in CI/CD will use that to produce the final readme

@garysassano
Copy link
Contributor Author

I reapplied the changes to the correct file.

@anitarua
Copy link
Contributor

anitarua commented Jan 6, 2025

Thanks, @garysassano!

One more small edit to fix this error would be much appreciated:

Error: Pull request has only one commit and it's not semantic; this may lead to a non-semantic commit in the base branch (see https://github.community/t/how-to-change-the-default-squash-merge-commit-message/1155). Amend the commit message to match the pull request title, or add another commit.

In the meantime, we're working on a way to get the remaining PR checks to pass on your branch, but will approve and merge this as soon as we are able.

@garysassano
Copy link
Contributor Author

Should be fine now.

@anitarua
Copy link
Contributor

anitarua commented Jan 8, 2025

Hi @garysassano! I think we have figured out how to run the PR checks on your branch. Can you sync your fork with our repo again?

I think you'll need to sync the main branch in your forked repo to get our updated workflow file, then rebase the PR branch onto the synced main branch in order to preserve your commit.

@garysassano
Copy link
Contributor Author

My branch is already in sync with main.

Copy link
Contributor

@anitarua anitarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for your contribution!

@anitarua anitarua merged commit 23ab035 into momentohq:main Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants