Repository navigation
ci: run Windows tests on windows-2022 COMPASS-11197 - #10
Merged
Merged
Conversation
gribnoysup
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the Windows jobs in #9 (COMPASS-11197), which fail on Node 20 and 22 for a reason unrelated to that PR.
windows-latestis now thewindows-2025-vs2026image (Visual Studio 2026). On Node 22 the bundlednode-gyp@11.5.0fails with:win-export-certificate-and-keyis an optional dependency built withnode-gyp rebuild, so npm silently skips it andnpm installsucceeds. The tests then fail withCannot find module 'win-export-certificate-and-key'. Node 24 passes because its newer npm bundles anode-gypthat recognises VS 2026.This pins the Windows job to
windows-2022(Visual Studio 2022), with a comment. It can go back towindows-latestonce thenode-gypbundled with Node 20/22 supports VS 2026.