Repository navigation
CSHARP-5030: Only modify TCP buffer sizes if explicitly configured - #2148
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the opt-in behavior or settings propagation; tests were not executed.
0 open findings
What changed in this PR
Adds an opt-in setting that leaves TCP buffer sizes under operating-system control while preserving the driver’s existing defaults.
Changes:
- Adds an obsolete compatibility setting, preserved when settings are copied or modified.
- Skips buffer-size assignments when enabled, while retaining socket customization.
- Tests default behavior, opt-in behavior, and settings propagation.
| File | Description |
|---|---|
| tests/MongoDB.Driver.Tests/Core/Connections/TcpStreamFactoryTests.cs | Tests buffer handling and socket customization. |
| tests/MongoDB.Driver.Tests/Core/Configuration/TcpStreamSettingsTests.cs | Tests setting defaults, copying, and updates. |
| src/MongoDB.Driver/Core/Connections/TcpStreamFactory.cs | Conditionally skips buffer-size assignments. |
| src/MongoDB.Driver/Core/Configuration/TcpStreamSettings.cs | Adds and preserves the opt-in setting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CSHARP-5030