Skip to content

fix(dashboard): remove API key table copy action - #1361

Open
jigjigjig wants to merge 2 commits into
mainfrom
jigjigjig/remove-api-key-table-copy
Open

jigjigjig wants to merge 2 commits into
mainfrom
jigjigjig/remove-api-key-table-copy

Conversation

@jigjigjig

@jigjigjig jigjigjig commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the copy control beside each fingerprint on the API keys page. The control copied only the stored prefix, not an API secret that could authenticate a request, so the clipboard action was misleading beside a recognition-only fingerprint. A stored key fingerprint is still shown for recognition, while copy remains available where the complete secret is handed over after creation or regeneration.

The change applies consistently to the desktop table and the mobile key list.

How to test it locally

  1. Open the API keys page with at least one key.
  2. Confirm the Key column shows the key fingerprint without a copy button.
  3. At a mobile viewport, confirm the key list also shows the fingerprint without a copy button.
  4. Create or regenerate a key and confirm the one-time secret dialog still offers its copy controls.

Automated checks completed:

  • make lint
  • make typecheck
  • Dashboard lint and TypeScript checks
  • Production dashboard build
  • API key page component suite, 49 tests
  • Full dashboard suite, 6,681 tests across 203 files

PR Type

  • New Feature
  • Bug Fix
  • Refactor
  • Documentation
  • Infrastructure / CI

Relevant issues

None.

Checklist

  • I understand the code I am submitting.
  • I have added or updated tests that cover my change (tests/unit, tests/integration).
  • I ran the Definition of Done checks locally (make lint, make typecheck, make test).
  • Documentation was updated where necessary.
  • If the API contract changed, I regenerated the OpenAPI spec (uv run python scripts/generate_openapi.py).
  • If this changes a rule in ARCHITECTURE.md or scripts/check_architecture.py, the description names the rule and says why.

AI Usage

  • No AI was used.
  • AI was used for drafting/refactoring.
  • This is fully AI-generated.

AI Model/Tool used: GPT-5.6 through Codex

Any additional AI details you'd like to share: The agent verified the existing control in the rendered component path and used git blame before implementing the change.

NOTE:
When responding to reviewer questions, please respond yourself rather than copy/pasting reviewer comments into an AI and pasting back its answer. We want to discuss with you, not your AI :)

  • I am an AI Agent filling out this form (check box if true)

Summary

Removed copy controls from API key fingerprints in the desktop table and mobile key list. Fingerprints remain visible for recognition.

Copy controls remain available in the one-time secret dialog after key creation or regeneration.

Testing

Updated tests to confirm that fingerprint copy controls are absent in both layouts.

Co-Authored-By: GPT-5.6 <noreply@openai.com>
@jigjigjig
jigjigjig requested review from a team, khaledosman and peteski22 and removed request for a team September 18, 2026 09:53
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bed93d84-1fb5-4737-9d9f-fc9e6dc31123

📥 Commits

Reviewing files that changed from the base of the PR and between 8964848 and 51d5efe.

📒 Files selected for processing (1)
  • web/src/features/keys/KeysPage.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The keys UI no longer provides key prefix copying in mobile or fingerprint views. The implementation uses a shared fingerprint renderer, and tests verify that the copy control is absent.

Changes

Key prefix copy removal

Layer / File(s) Summary
Remove copy affordance and update tests
web/src/features/keys/KeysPage.tsx, web/src/features/keys/KeysPage.test.tsx
The fingerprint views now render only the fingerprint or an em dash. Mobile and fingerprint tests verify that the key prefix copy button is not rendered.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 51d5e

The change removes key-prefix copying while preserving fingerprint display across desktop and mobile views, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses the Conventional Commit prefix fix(dashboard):, describes the removal of the API key fingerprint copy action, uses imperative mood, and is under 70 characters.
Description check ✅ Passed The description includes all required sections, clearly explains the user-facing change, provides local and automated test steps, identifies the PR type, documents AI usage, and completes the relevant…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khaledosman khaledosman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cleanup inline.

One thing for the description rather than the code: this reverses the prefix copying #1225 added deliberately two days ago (step 4 of that PR's test plan named it), and the body here says what changed without saying what was wrong with it. Worth a line on the reason, since fix: puts "remove API key table copy action" under Bug Fixes in the release notes.


🤖 Review generated with Claude Code (Opus 5)

Comment thread web/src/features/keys/KeysPage.tsx Outdated
Co-Authored-By: GPT-5.6 <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants