Repository navigation
Conversation
… custom tab for the sign-in flow.
t-p-white
marked this pull request as ready for review
October 26, 2026 14:58
|
No new issues detected. This pull request is 🆗 |
rocketsroger
approved these changes
Oct 26, 2026
rocketsroger
left a comment
rocketsroger
left a comment
Contributor
There was a problem hiding this comment.
Looks good. One question unrelated to this change but we might want to update.
Contributor
Author
lando-worker Bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
… custom tab for the sign-in flow. r=roger A QR-scanned pairing link (`accounts.firefox.com/pair#channel_id=...`) reaches Firefox through the App Links filter on `IntentReceiverActivity`. Previously, it fell through to the regular tab processor, leaving the FxA page open as a normal tab after sign-in or when abandoned. `IntentReceiverActivity` now records `pairing_link_opened` and opens the link with `createAuthCustomTabIntent`, the same route every sign-in entry point takes into `AuthCustomTabActivity`. That activity finishes on `onAuthenticated` and removes its custom tab whenever it is left, so neither success nor abandonment leaves a tab behind. Pairing links no longer count towards `opened_link`. This mirrors `PairFragment`, which handles the same URL from the in-app QR scanner: - **In-app scanner:** `PairFragment` hands the URL to the native pairing flow and opens the resulting `/pair/supp` OAuth URL in the auth custom tab. - **External scanner:** the `/pair` page itself loads in the auth custom tab, and FxA starts OAuth over the pairing v2 web channel. Both complete through the `fxaccounts:oauth_login` web channel message. The receiver’s transparent theme and the application context both lack the Material `colorSurface` attribute that `createCustomTabIntent` reads, so the intent is built using a `ContextThemeWrapper` with `NormalTheme`. Pull request: #415
|
Pull request closed by commit 7d5b730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A QR-scanned pairing link (
accounts.firefox.com/pair#channel_id=...) reaches Firefox through the App Links filter onIntentReceiverActivity. Previously, it fell through to the regular tab processor, leaving the FxA page open as a normal tab after sign-in or when abandoned.IntentReceiverActivitynow recordspairing_link_openedand opens the link withcreateAuthCustomTabIntent, the same route every sign-in entry point takes intoAuthCustomTabActivity. That activity finishes ononAuthenticatedand removes its custom tab whenever it is left, so neither success nor abandonment leaves a tab behind. Pairing links no longer count towardsopened_link.This mirrors
PairFragment, which handles the same URL from the in-app QR scanner:PairFragmenthands the URL to the native pairing flow and opens the resulting/pair/suppOAuth URL in the auth custom tab./pairpage itself loads in the auth custom tab, and FxA starts OAuth over the pairing v2 web channel.Both complete through the
fxaccounts:oauth_loginweb channel message.The receiver’s transparent theme and the application context both lack the Material
colorSurfaceattribute thatcreateCustomTabIntentreads, so the intent is built using aContextThemeWrapperwithNormalTheme.Lando: link
Bugzilla: bug 2068241
🚫 This pull request has 1 blocker.