Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .venv to .gitignore #15823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add .venv to .gitignore #15823

wants to merge 1 commit into from

Conversation

stephaniehobson
Copy link
Contributor

Add .venv to .gitignore

@stephaniehobson stephaniehobson requested a review from pmac January 7, 2025 20:14
@@ -13,6 +13,7 @@ __pycache__/
.noseids
.python-version
.vscode/*
.venv/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entry for venv (no dot) is down on line 66, and it doesn't include the /* at the end. I wonder if that /* is necessary, and if so what it's doing? I'll have a look at the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs it seems like it's equivalent for our purposes. I guess we should just be consistent. Technically .venv would match a directory or file with that name. .venv/ would match only a directory. .venv/* matches anything directly inside that directory up to another slash. .venv/** would match everything inside the dir no matter how deep.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (0358717) to head (77916a4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15823      +/-   ##
==========================================
- Coverage   79.11%   79.10%   -0.02%     
==========================================
  Files         160      160              
  Lines        8376     8309      -67     
==========================================
- Hits         6627     6573      -54     
+ Misses       1749     1736      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants