chore: Enable the unused_result_ok lint
#2333
Merged
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also exposed an unneeded `Result` being returned from `stream_fairness`, which this PR also removes.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to e5770ce. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
reviewed
Jan 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2333 +/- ##
==========================================
- Coverage 93.33% 93.32% -0.02%
==========================================
Files 114 114
Lines 36887 36891 +4
Branches 36887 36891 +4
==========================================
Hits 34428 34428
- Misses 1679 1682 +3
- Partials 780 781 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lars Eggert <[email protected]>
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.168 µs 11.221 µs 11.289 µs]
change: [-0.0548% +0.3713% +0.9029%] (p = 0.11 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0161 ms 3.0253 ms 3.0359 ms]
change: [-0.6057% -0.1078% +0.4054%] (p = 0.67 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.551 µs 19.674 µs 19.867 µs]
change: [-0.5086% +0.4197% +1.4428%] (p = 0.44 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1582 ms 5.1694 ms 5.1822 ms]
change: [-0.4588% -0.1300% +0.2050%] (p = 0.47 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5344 µs 5.5550 µs 5.5835 µs]
change: [-0.7775% +0.0900% +1.0671%] (p = 0.86 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7593 ms 1.7596 ms 1.7598 ms]
change: [-0.7047% -0.3225% -0.0107%] (p = 0.06 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.474 ns 98.767 ns 99.083 ns]
change: [-0.4626% -0.0224% +0.3893%] (p = 0.92 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.48 ns 117.34 ns 118.73 ns]
change: [-0.9889% +0.1196% +1.3106%] (p = 0.86 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.11 ns 116.41 ns 116.82 ns]
change: [-0.6089% +0.0248% +0.6138%] (p = 0.95 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.090 ns 98.258 ns 98.452 ns]
change: [-0.5595% +0.6695% +1.9621%] (p = 0.31 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [110.95 ms 111.01 ms 111.07 ms]
change: [-0.2788% -0.0802% +0.0526%] (p = 0.45 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4030 µs 5.4796 µs 5.5499 µs]
change: [-1.9965% +2.7487% +10.372%] (p = 0.49 > 0.05)
transfer/pacing-false/varying-seeds: 💔 Performance has regressed. time: [43.788 ms 43.888 ms 43.992 ms]
change: [+4.8647% +5.1930% +5.5182%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [44.047 ms 44.118 ms 44.191 ms]
change: [+4.7546% +4.9965% +5.2568%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💔 Performance has regressed. time: [43.613 ms 43.683 ms 43.758 ms]
change: [+4.2064% +4.4605% +4.7213%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [43.602 ms 43.675 ms 43.753 ms]
change: [+3.4793% +3.7368% +3.9881%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [891.63 ms 902.08 ms 912.78 ms]
thrpt: [109.56 MiB/s 110.86 MiB/s 112.15 MiB/s]
change:
time: [+0.1378% +1.7113% +3.3545%] (p = 0.04 < 0.05)
thrpt: [-3.2456% -1.6825% -0.1376%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [300.02 ms 301.86 ms 303.71 ms]
thrpt: [32.926 Kelem/s 33.128 Kelem/s 33.332 Kelem/s]
change:
time: [-1.0959% -0.1701% +0.7537%] (p = 0.72 > 0.05)
thrpt: [-0.7481% +0.1704% +1.1081%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.286 ms 34.482 ms 34.702 ms]
thrpt: [28.817 elem/s 29.001 elem/s 29.167 elem/s]
change:
time: [-0.3450% +0.5148% +1.3656%] (p = 0.24 > 0.05)
thrpt: [-1.3472% -0.5121% +0.3462%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.6124 s 1.6313 s 1.6501 s]
thrpt: [60.604 MiB/s 61.302 MiB/s 62.020 MiB/s]
change:
time: [-3.3357% -1.6884% -0.1312%] (p = 0.04 < 0.05)
thrpt: [+0.1313% +1.7174% +3.4508%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
mxinden
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore errors explicitly.