Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add esm support #53

Merged
merged 1 commit into from
Nov 12, 2024
Merged

ci: Add esm support #53

merged 1 commit into from
Nov 12, 2024

Conversation

rmi22186
Copy link
Collaborator

@rmi22186 rmi22186 commented Nov 8, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Issue #49 mentions building an ESM module. I noticed ESM is only built on our core library and not our kits. When we get to refining our CI/CD more, we should restructure and have this be more automated so not every kit needs to be updated, but for now I am adding this to quickly get it to market.

Testing Plan

  • Was this tested locally? If not, explain why.
    Builds esm file locally

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle self-assigned this Nov 8, 2024
@rmi22186 rmi22186 merged commit a5ffb6f into master-v5 Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants