-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Add Api
type param to cell params model
#15968
base: master
Are you sure you want to change the base?
Conversation
Api
type param to cell params interfacesApi
type param to cell params model
Deploy preview: https://deploy-preview-15968--material-ui-x.netlify.app/ |
@michelengelen, could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would like a second review from @arminmeh about this.
Is this expected from the users? Looking backwards, I think that we shouldn't have done this This made We are not accessing @mui/xgrid should we remove |
Not sure what you mean here. |
true, but we added another public point of accessing it. |
|
I think we should be removing |
Closes #15963