added resource: Chemical Ladder v2.0 (ladders) #547
Conversation
|
Looks pretty cool. This is going to take a while to code review, but the first step would be to look at what the linter has flagged and address those issues. Just to confirm on the record - are you the original author of the resource? |
|
For the record yes. |
|
Awesome scripts! Looking forward to this |
|
Any updates on this? |
This step was not done as far as I can see, so no, there are no updates. |
| local climbers = {} | ||
| local climbs = {} | ||
|
|
||
| local anim = anims |
There was a problem hiding this comment.
This is unnecessary, because the anims table is a global variable, so it is accessible in this script from the global namespace
| local anim = anims |
| local minus | ||
| do | ||
| local abs = math.abs | ||
| -- calculate and return the distance unit2 | ||
| -- needs to move to reach unit1 | ||
| function minus(unit1, unit2) | ||
| local phi = abs(unit2-unit1) % 360 | ||
| local sign = 1 | ||
| -- used to calculate sign | ||
| if not ((unit1-unit2 >= 0 and unit1-unit2 <= 180) | ||
| or (unit1-unit2 <= -180 and unit1-unit2 >= -360)) then | ||
| sign = -1 | ||
| end | ||
| if phi > 180 then | ||
| result = 360-phi | ||
| else | ||
| result = phi | ||
| end | ||
|
|
||
| return result*sign | ||
| end | ||
| end |
There was a problem hiding this comment.
This can be implemented much more simply, how about this solution?
| local minus | |
| do | |
| local abs = math.abs | |
| -- calculate and return the distance unit2 | |
| -- needs to move to reach unit1 | |
| function minus(unit1, unit2) | |
| local phi = abs(unit2-unit1) % 360 | |
| local sign = 1 | |
| -- used to calculate sign | |
| if not ((unit1-unit2 >= 0 and unit1-unit2 <= 180) | |
| or (unit1-unit2 <= -180 and unit1-unit2 >= -360)) then | |
| sign = -1 | |
| end | |
| if phi > 180 then | |
| result = 360-phi | |
| else | |
| result = phi | |
| end | |
| return result*sign | |
| end | |
| end | |
| function minus(unit1, unit2) | |
| local diff = unit2 - unit1 | |
| local diffNormalized = diff % 360 | |
| return diffNormalized > 180 and diffNormalized - 360 or diffNormalized | |
| end |
There was a problem hiding this comment.
Looks good, don't see why not as long as it works.
| function getPedsOnLadder(surface) | ||
| local peds = {} | ||
| for ped, data in pairs(climbers) do | ||
| if surface==nil then |
There was a problem hiding this comment.
| if surface==nil then | |
| if not surface then |
There was a problem hiding this comment.
I wouldn't recommend that. nil and false aren't the same, they are done like that for a reason.
There was a problem hiding this comment.
I wouldn't recommend that. nil and false aren't the same, they are done like that for a reason.
In this case, it will not change how it works, and the change I suggested is a better solution
| function isPedLadderClimbingEnabled(ped) | ||
| local eType = ped and isElement(ped) and getElementType(ped) | ||
| assert(eType=="ped" or eType=="player") -- isPed | ||
| if climbers[ped]==false then return false end |
There was a problem hiding this comment.
| if climbers[ped]==false then return false end | |
| if not climbers[ped] then return false end |
| local dist = ((tx-sx)^2+(ty-sy)^2+(tz-sz)^2)^.5+10 | ||
| if ((tx-px)^2+(ty-py)^2+(tz-pz)^2)^.5<dist or ((px-sx)^2+(py-sy)^2+(pz-sz)^2)^.5<dist then | ||
| local dist, p = getPointDistanceFromLadder(px, py, pz, sx, sy, sz, tx, ty, tz) | ||
| if (climbD==nil or dist<climbD) then |
There was a problem hiding this comment.
| if (climbD==nil or dist<climbD) then | |
| if (not climbD or dist<climbD) then |
| local eType = ped and isElement(ped) and getElementType(ped) | ||
| assert(eType=="ped" or eType=="player") -- isPed | ||
| if climbers[ped]==false then return false end | ||
| return climbers[ped]==nil or (climbers[ped] and true) |
There was a problem hiding this comment.
Do realize this is supposed to return true when it's nil.
| return false | ||
| end | ||
|
|
||
| do |
There was a problem hiding this comment.
Why is this do block necessary?
| function removeLadder(surface, ladder) | ||
| local surfaceData = climbs[surface] | ||
| assert(surfaceData) | ||
| if ladder==nil then |
There was a problem hiding this comment.
| if ladder==nil then | |
| if not ladder then |
| addDebugHook("preFunction", function(sourceResource, functionName, isAllowedByACL, luaFilename, luaLineNumber, ped) -- just to deal with freeroam | ||
| if sourceResource~=resource and climbers[ped] then | ||
| return "skip" | ||
| end | ||
| end, {"setPedAnimation"}) |
| addDebugHook("postFunction", function(sourceResource, functionName, isAllowedByACL, luaFilename, luaLineNumber, ...) | ||
| end, {"createVehicle", "Vehicle", "createObject", "Object"}) |
| local eType = ped and isElement(ped) and getElementType(ped) | ||
| assert(eType=="ped" or eType=="player") -- isPed | ||
| if climbers[ped]==false then return false end | ||
| return climbers[ped]==nil or (climbers[ped] and true) |
There was a problem hiding this comment.
Do realize this is supposed to return true when it's nil.
Adds a resource that allows you to climb various ladders across SA map. Default ladders can be added or disabled via exported functions. This also allows you to add ladders to elements based on modelID (vehicle and object supported).
https://youtu.be/K3JhbzGyQto?si=84lkPPM4I3R189mh