-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubygems deprecations #11
base: master
Are you sure you want to change the base?
Conversation
- Gem.all_load_paths() has been deprecated recently. Not only that - some of the other deprecated methods it depends on uses have probably not not been updated in a long time and cause 'rake gettext:find' to crash ('undefined method `specifications' for "/usr/lib/ruby/gems/1.9.1":String'). - This patch iterates over all specifications and collects values of their gem_dir properties in an array instead - Use only those specifications that have been activated. The old implementation was using all of them, even if there were multiple versions of the same gem.
- My patch that fixes the use of deprecated Gem.all_load_paths() uses rubygems features that have been added in version 1.8.0. Make that requirement explicit.
+1. Please pull and release new gem. This bug drove me crazy :-( |
+1 Please pull. |
+1 please pull. very annoying bug |
I also wrote another patch for this issue. This probably works with any version of Rubygems.
|
come on sort it out! |
+1 pls ... |
I'm having a strange behaviour using @cameel 's fix. It works for finding and packing the files, but on runtime, any translated string containing variables won't work properly. Example:
will show in the view
This happens all along my site, only after this fix. Ideas? |
my hotfix :) module Gem;def self.all_load_paths;[];end;end |
any new on oficial fix for this issue? |
Switch over to the maintained ruby gettext : http://ruby-gettext.github.com/ / https://github.com/ruby-gettext/gettext |
They both push to the same gem, is there a difference ? |
Doh! You're right :) |
I got push permission from @mutoh. I want to work together with fast_gettext if available. |
gettext is using deprecated method Gem.all_load_paths from RubyGems. This makes 'rake gettext:find' crash in the process of generating locale files.
I fixed it, but my fix depends on newer version of RubyGems (obviously, deprecated calls had to be replaced with their newer alternatives). You may want to pull it anyway so I make this pull request.