Accessibility improvements

[vvillenave]

Greetings,
this is a proposal for some accessibility improvements (mainly labelling).
A rather big remaining issue is that the status columns in the TreeView
are still not exposed, and that the context menu for packages still isn’t
accessible through keyboard input. But I’m gonna tackle that another
time hopefully...

[vvillenave]

Guys, any comments on this PR? @mvo5? @BryanQuigley?

[BryanQuigley]

These are generic comments - I'm not using synaptic atm - doing some distro hopping... anyway.. (and wait to see what @mvo5 says before making any big changes)

FIXMEs I would drop all changes to the files you don't think are used any make a separate list of them (and maybe another PR to remove them.

In my limited understanding:
"Accessibility: add proper labelling relations" looks like it really couldn't cause any regressions.
while the other two could potentially cause regressions. - Might be worth separate PRs.

[hamishmb]

I'm not a contributor here, but this looks like a decent set of changes to me. I concur that the labelling seems unlikely to cause any issues.

I'm not sure why the invisible cursor improves accessibility though - I often find it confusing when the cursor isn't visible, especially if I'm controlling a system over eg VNC.

[mvo5]

Thanks for the PR and sorry that it took me forever to reply here. I had a look over the first commit and it looks interesting and like a good improvement, however when trying to run it, I get:

$ make && sudo ./synaptic
Making all in gtkbuilder
...

** (synaptic:15637): WARNING **: 17:36:10.903: Couldn't load builder file: gtkbuilder/window_main.ui:1288:1 Duplicate object ID 'label_source' (previously on line 1271)

(synaptic:15637): Gtk-CRITICAL **: 17:36:10.910: gtk_widget_show: assertion 'GTK_IS_WIDGET (widget)' failed

(synaptic:15637): GLib-GObject-CRITICAL **: 17:36:10.910: invalid (NULL) pointer instance

(synaptic:15637): GLib-GObject-CRITICAL **: 17:36:10.910: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(synaptic:15637): Gtk-CRITICAL **: 17:36:10.910: gtk_combo_box_set_model: assertion 'GTK_IS_COMBO_BOX (combo_box)' failed

(synaptic:15637): Gtk-CRITICAL **: 17:36:10.910: gtk_cell_layout_clear: assertion 'GTK_IS_CELL_LAYOUT (cell_layout)' failed

(synaptic:15637): Gtk-CRITICAL **: 17:36:10.910: gtk_cell_layout_pack_start: assertion 'GTK_IS_CELL_LAYOUT (cell_layout)' failed

(synaptic:15637): Gtk-CRITICAL **: 17:36:10.910: gtk_cell_layout_add_attribute: assertion 'GTK_IS_CELL_LAYOUT (cell_layout)' failed

(synaptic:15637): Gtk-CRITICAL **: 17:36:10.910: gtk_combo_box_set_active: assertion 'GTK_IS_COMBO_BOX (combo_box)' failed
synaptic: rgmainwindow.cc:821: RGMainWindow::RGMainWindow(RPackageLister*, std::string): Assertion `progress' failed.
Aborted

Did I miss anything when testing this?