Fix compilation for tools/armips.cpp by removing #undef __STRICT_ANSI__ #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function strcasecmp from armips/946338745955fef3a5528eefeb947751aae9363c
|
Tested with latest Cygwin, works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time the single file for armips was created, there was a reliance on non-standard function strcasecmp() in armips. According to armips/79bf12b02ffe1feb39e4e529fb13ccedf3102339, this was required to fix the build with Cygwin at the time. However, this breaks headers which are configured based on STRICT_ANSI. For me, this resulted in compilation failing with GCC 14.2.1 on Arch Linux.
Commit armips/946338745955fef3a5528eefeb947751aae9363c replaces the one use of strcasecmp with its own implementation, and commit armips/2205628e245e9f4ca5fc90cb7c39fe8457729077 removes the #undef __STRICT_ANSI.
I simply applied the fix from armips/946338745955fef3a5528eefeb947751aae9363c and removed the #undef STRICT_ANSI, which fixes the build.